Support animation of SVG color properties #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert.equal(webAnimations1.propertyInterpolation('color', 'transparent', '#004488')(0.5), 'rgba(0,68,136,0.500)'); | ||
| assert.equal(webAnimations1.propertyInterpolation('color', 'red', 'green')(2), 'rgba(0,255,0,1)'); | ||
| assert.equal(webAnimations1.propertyInterpolation('color', 'red', 'green')(-1), 'rgba(255,0,0,1)'); | ||
| assert.equal(webAnimations1.propertyInterpolation('fill', 'transparent', '#004488')(0), 'transparent'); |
There was a problem hiding this comment.
I think we need to use something other than 0 for the progress on this test, to distinguish successful interpolation from a 50-50 flip.
There was a problem hiding this comment.
The subsequent line has the same from/to colors with 50% progress.
ewilligers
force-pushed
the
additional-color-properties
branch
from
8e4a8de to
9023438
Compare
|
lgtm |
Animation of 'fill', 'flood-color', 'lighting-color', 'stop-color', 'stroke' is now supported.
ewilligers
force-pushed
the
additional-color-properties
branch
from
9023438 to
027c534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animation of 'fill', 'flood-color', 'lighting-color', 'stop-color',
'stroke' is now supported.
web-animations/web-animations-js#81