-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Consider bumping the version of dependency scrypt.js from 0.2.0 to 0.3.0 #2385
Comments
Thanks for submitting this issue. Could you update this issue to be align with the issue template? |
No problem. I have updated the template. |
Hi there, Context I am following a step by step introduction from this video (made by Gregory) where he is using the
Here my questions
|
Sorry. After reading this three times I still do not understand the issue. For me this works fine. Can you maybe provide a |
Until then I would say that this is a non-important issue and should be dropped from the 1.0 Milestone. |
I just got here from #2770. The install of |
Using |
On the deprecated If you are using |
Is this going to be published any time soon? |
Expected behavior
The now deprecated node-scrypt should be an optional dependency.
Actual behavior
web3-eth-accounts depends on scrypt.js which has recently released a new version.
This version allows the users to optionally exclude the package node-scrypt
node-scrypt is treated as an optional dependency and users specifying --no-optional will install the JS-version of scrypt, scryptsy, only.
This is important because node-scrypt relies on node-gyp bindings and is problematic to install on some systems.
By bumping scrypt.js to 0.3.0 we will also be making node-scrypt optional.
Users not specifying --no-optional on installation will not be affected by this change.
Steps to reproduce the behavior
Versions
web3.js 1.0
On a side note, node-scrypt is considered deprecated by the author since Node now has a standard library for scrypt.
It would be awesome if we could move to this long-term.
The text was updated successfully, but these errors were encountered: