Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Dependencies of the accounts module updated #2780

Merged
merged 5 commits into from
May 6, 2019
Merged

Dependencies of the accounts module updated #2780

merged 5 commits into from
May 6, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented May 4, 2019

Description

Fixes #2385

Type of change

  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Enhancement Includes improvements or optimizations In Progress Currently being worked on labels May 4, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 95.976% when pulling b480731 on issue/2385 into efd2274 on 1.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 95.976% when pulling b480731 on issue/2385 into efd2274 on 1.0.

@coveralls
Copy link

coveralls commented May 4, 2019

Coverage Status

Coverage decreased (-0.001%) to 95.979% when pulling 382ad68 on issue/2385 into 5c4aefb on 1.0.

@nivida nivida removed the In Progress Currently being worked on label May 6, 2019
@nivida nivida merged commit 5eab09d into 1.0 May 6, 2019
@nivida nivida deleted the issue/2385 branch May 7, 2019 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider bumping the version of dependency scrypt.js from 0.2.0 to 0.3.0
2 participants