Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

IpcProvider chunks handling fix #2545

Merged
merged 13 commits into from
Mar 22, 2019
Merged

IpcProvider chunks handling fix #2545

merged 13 commits into from
Mar 22, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Mar 21, 2019

Description

Fixes #2539

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Mar 21, 2019
@coveralls
Copy link

coveralls commented Mar 21, 2019

Coverage Status

Coverage decreased (-0.08%) to 98.575% when pulling 34b5139 on issue/2539 into 1a7c600 on 1.0.

@nivida nivida removed the In Progress Currently being worked on label Mar 22, 2019
@nivida nivida merged commit 2cfff78 into 1.0 Mar 22, 2019
@nivida nivida deleted the issue/2539 branch March 22, 2019 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribe to pendingTransactions fails while using IPC Provider
2 participants