This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fix issue decoding log with only indexed parameters #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivida
suggested changes
Mar 22, 2019
| @@ -229,7 +229,7 @@ export default class AbiCoder { | |||
| nonIndexedInputItems.push(input); | |||
| }); | |||
|
|
|||
| if (data) { | |||
| if (data && data !== '0x') { | |||
There was a problem hiding this comment.
Could you handle the '0x' case here: https://github.com/ethereum/web3.js/blob/1.0/packages/web3-eth-contract/src/decoders/EventLogDecoder.js#L50
Thanks for the PR!
There was a problem hiding this comment.
Would something like
if (response.data === '0x') delete response.data suffice?
Is that what you meant?
There was a problem hiding this comment.
I would do it this way:
if (response.data === '0x') {
reponse.data = null;
}
angus-hamill
force-pushed
the
indexed-logs-fix
branch
from
e423d93 to
2ce2412
Compare
nivida
approved these changes
Mar 22, 2019
|
@angus-hamill FYI: I'll release this fix when I've closed the issue #2539 |
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a log has only indexed parameters, the data field may still be present as
0x. TheAbiCoderwas attempting to decode this and erroring.Type of change
Checklist:
npm run testin the root folder with success and extended the tests if necessary.npm run buildin the root folder and tested it in the browser and with node.npm run dtslintin the root folder and tested that all my types are correct