Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Breaking change of Wallet class fixed and test updated #2592

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Breaking change of Wallet class fixed and test updated #2592

merged 1 commit into from
Mar 27, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Mar 27, 2019 •
edited
Loading

Description

Fixes #2591

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on and removed In Progress Currently being worked on labels Mar 27, 2019
@nivida nivida merged commit 9dfc93e into 1.0 Mar 27, 2019
@nivida nivida deleted the issue/2591 branch March 27, 2019 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web3.eth.accounts.wallet typings and documentation
1 participant
@nivida