Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

documentation added for web3-eth-admin module & pendingTransactions #2658

Merged
merged 7 commits into from
Apr 15, 2019

Conversation

princesinha19
Copy link
Contributor

Description

I have added the documentation for web3-eth-admin module and eth.pendingTranactions.
It's dependent to #2655, #2657.

  • Documentation

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.374% when pulling e3e425d on princesinha19:document_web3 into 839283a on ethereum:1.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.374% when pulling e3e425d on princesinha19:document_web3 into 839283a on ethereum:1.0.

@coveralls
Copy link

coveralls commented Apr 6, 2019

Coverage Status

Coverage remained the same at 95.376% when pulling 50f96b4 on princesinha19:document_web3 into be9582b on ethereum:1.0.

@princesinha19 princesinha19 changed the title documentation added for web3-eth-admin mosule & pendingTransactions documentation added for web3-eth-admin module & pendingTransactions Apr 6, 2019
@nivida nivida added Documentation Relates to project wiki or documentation In Progress Currently being worked on labels Apr 8, 2019
@nivida nivida removed the In Progress Currently being worked on label Apr 8, 2019
@nivida nivida added the In Progress Currently being worked on label Apr 8, 2019
@nivida
Copy link
Contributor

nivida commented Apr 8, 2019

I will extend the docs a bit with some additional details. @princesinha19

@princesinha19
Copy link
Contributor Author

okay, cool @nivida.

@princesinha19
Copy link
Contributor Author

Done all the changes.

@nivida nivida removed the In Progress Currently being worked on label Apr 15, 2019
@nivida nivida merged commit 617c2dd into web3:1.0 Apr 15, 2019
@princesinha19 princesinha19 deleted the document_web3 branch April 23, 2019 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Relates to project wiki or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants