This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
txpool management API's implemented (web3-eth-txpool) #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivida
suggested changes
Apr 8, 2019
packages/web3-core-method/src/methods/txpool/GetTxpoolContentMethod.js
Outdated
Show resolved
Hide resolved
nivida
approved these changes
Apr 8, 2019
If this has to get to through https://github.com/ethereum/web3.js/blob/1.0/packages/web3-eth/types/index.d.ts Please add it |
@joshstevens19 Done changes. |
joshstevens19
approved these changes
Apr 12, 2019
@joshstevens19 thanks for your suggestions. So, I removed this module to get exposed through web3.eth. So, can you please review the new commit? |
joshstevens19
approved these changes
Apr 12, 2019
nivida
suggested changes
Apr 15, 2019
nivida
approved these changes
Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I implemented all txpool management API's provided by geth.
https://github.com/ethereum/go-ethereum/wiki/Management-APIs#list-of-management-apis
Fixes partially #2637
Type of change
Checklist:
npm run test
in the root folder with success and extended the tests if necessary.npm run build
in the root folder and tested it in the browser and with node.npm run dtslint
in the root folder and tested that all my types are correct