Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

web3-eth-miner documentation #2663

Merged
merged 5 commits into from
Apr 16, 2019
Merged

Conversation

princesinha19
Copy link
Contributor

Description

Documentation added for web3-eth-miner. All methods of miner listed in https://github.com/ethereum/go-ethereum/wiki/Management-APIs#miner.

Releated to: #2660

Type of change

  • Documentation

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@coveralls
Copy link

coveralls commented Apr 8, 2019

Coverage Status

Coverage remained the same at 95.491% when pulling 5afd630 on princesinha19:miner-documentation into bb891b2 on ethereum:1.0.

@nivida nivida added the Documentation Relates to project wiki or documentation label Apr 9, 2019
@nivida nivida added the In Progress Currently being worked on label Apr 14, 2019
@nivida nivida removed the In Progress Currently being worked on label Apr 15, 2019
@princesinha19
Copy link
Contributor Author

@nivida I changed the Miner documentation. I think you should review the latest commit. I changed Txpool and Admin documentation too.

@nivida nivida merged commit b18a1eb into web3:1.0 Apr 16, 2019
@princesinha19 princesinha19 deleted the miner-documentation branch April 23, 2019 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Relates to project wiki or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants