Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Calling new Web3() without a provider. #2700

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Calling new Web3() without a provider. #2700

merged 3 commits into from
Apr 17, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Apr 17, 2019

Description

Fixes #2689

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Apr 17, 2019
@joshstevens19
Copy link
Contributor

Don't forget to update the typing's here 👍 https://github.com/ethereum/web3.js/blob/1.0/packages/web3/types/index.d.ts#L32

@coveralls
Copy link

coveralls commented Apr 17, 2019

Coverage Status

Coverage increased (+0.003%) to 95.548% when pulling b5410bc on issue/2689 into b18a1eb on 1.0.

@nivida nivida removed the In Progress Currently being worked on label Apr 17, 2019
@nivida nivida merged commit 7debe34 into 1.0 Apr 17, 2019
@nivida nivida deleted the issue/2689 branch April 17, 2019 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling new Web3() without a provider breaks
3 participants