This repository was archived by the owner on Mar 5, 2025. It is now read-only.
add: custom transaction polling interval (#4584) #4672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add: custom transaction polling interval allow to set via options the interval which polls for TX status * add: transactionPollingInterval to contract * add: pass transactionPollingInterval to method * Update CHANGELOG.md * add: transactionPollingInterval docs Co-authored-by: Nazar Hussain <[email protected]>
|
Your Render PR Server URL is https://web3-js-pr-4672.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7bqaqpg7hpbv8633jk0. |
14 tasks
nazarhussain
approved these changes
Jan 7, 2022
jdevcs
reviewed
Jan 7, 2022
CHANGELOG.md
Outdated
| @@ -484,7 +484,8 @@ Released with 1.0.0-beta.37 code base. | |||
|
|
|||
| ### Added | |||
| - `maxPriorityFeePerGas` and `maxFeePerGas` added to `Transaction` and `TransactionConfig` interfaces (#4232) (#4585) | |||
|
|
|||
| - `transactionPollingInterval` added to web3, contract and method constructor options. defaults to 1 second. (#4584) | |||
There was a problem hiding this comment.
1.7.0 is already frozen under 1.7.0-rc so this change should be under future release instead of 1.7.0
jdevcs
suggested changes
Jan 7, 2022
Co-authored-by: jdevcs <[email protected]>
Co-authored-by: jdevcs <[email protected]>
luu-alex
approved these changes
Jan 14, 2022
Pull Request Test Coverage Report for Build 1699133797
💛 - Coveralls |
jdevcs
approved these changes
Jan 14, 2022
This was referenced Feb 11, 2022
This was referenced Feb 11, 2022
This was referenced Mar 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transactionPollingIntervaltoweb3-ethtransactionPollingIntervaltests