This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Update xhr2-cookies deps for 1.x, fix User-Agent header problem #4796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unlike ethers.js, web3.js didn't support using custom
User-Agent
headers due to header restrictions inherited from the old, unmaintained xhr2-cookies dependencies.Related issues:
#1803
#2158
Using old dependency would expose the OS and nodejs version to RPC providers.
Due to this problem, there are many forks of the old dependencies exist https://www.npmjs.com/package/xhr2-cookies-web3fix , only to fix this old restriction applied.
See also
souldreamer/xhr2-cookies#30
Type of change
Changed only dependencies to local, github fork https://github.com/0xAyanami/xhr2-cookies.git. Would be great if the ChainSafe or any web3.js maintainer could fork my commits and change the repository address.
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.