Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

updating pull request template #5310

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Aug 3, 2022

#5186

Description

Updating the PR template to include a 4.x checklist, PR templates must be updated on the default branch (1.x).

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@render
Copy link

render bot commented Aug 3, 2022

@jdevcs jdevcs added the 4.x 4.0 related label Aug 9, 2022
@jdevcs
Copy link
Contributor

jdevcs commented Aug 9, 2022

Also open PR for merging it in 4.x branch, for future use. @luu-alex

@spacesailor24 spacesailor24 merged commit d64a26a into 1.x Aug 17, 2022
@spacesailor24 spacesailor24 deleted the update-pullrequest-template branch August 17, 2022 18:55
@luu-alex luu-alex mentioned this pull request Aug 20, 2022
1 task
This was referenced Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants