This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://web3-js-pr-5354.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbu1dfs41ls8fdb1ku70. |
Pull Request Test Coverage Report for Build 2878018154
💛 - Coveralls |
074529d
to
0ea714c
Compare
LGTM, for :
wts are error logs? |
jdevcs
approved these changes
Aug 18, 2022
Is this duplicate PR #5314 ? For current PR, also mention it in changelog. Thanks |
16 tasks
nikoulai
approved these changes
Aug 18, 2022
@jdevcs when using node 14 and node 16 node-gyp has an error installing and mosaic has a test contract error. heres the CI |
@jdevcs yes is a duplicate, will close the other |
This was referenced Oct 23, 2022
This was referenced Jan 2, 2023
This was referenced Feb 15, 2023
This was referenced Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4888 Updating node version for builds and fixing mosaic tests that were failing due to node 12 version. Was running into issues trying to include more node versions with what seemed like random 1-2 test cases failing
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.