This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fix: add missing function type "receive" (#5165) e2e Tests #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix: add missing function type "receive"
This PR adds missing type "receive"
example in solidity:
```solidity
receive() external payable {
// any code
}
```
* Update Changgelog
* Update CHANGELOG.md
* Update CHANGELOG.md
Co-authored-by: Oleksii Kosynskyi <[email protected]>
Co-authored-by: Junaid <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]>
|
Your Render PR Server URL is https://web3-js-pr-5417.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ccbk4ohgp3jgs3bqaiqg. |
|
All changes of this PR are approved in #5165 and CI is green here so merging in 1.x |
This was referenced Oct 23, 2022
This was referenced Jan 2, 2023
This was referenced Feb 15, 2023
This was referenced Feb 15, 2023
This was referenced Feb 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for e2e test of #5165
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist for 1.x:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.