Skip to content
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Critical dependency since [email protected] #15

Closed
jhnns opened this issue Oct 8, 2014 · 7 comments · Fixed by browserify/crypto-browserify#58
Closed

Critical dependency since [email protected] #15

jhnns opened this issue Oct 8, 2014 · 7 comments · Fixed by browserify/crypto-browserify#58

Comments

@jhnns
Copy link
Member

jhnns commented Oct 8, 2014

@dominictarr introduced with browserify/crypto-browserify@9284566 a change which triggers a critical dependency warning due to a dynamic require.

What should we do @sokra? ^^

@sokra
Copy link
Member

sokra commented Oct 8, 2014

... Why?

@dominictarr
Copy link

this isn't really a dynamic require, this is just to make crypto-browserify runnable in node, without browserify trying to load itself.

@charandas
Copy link

@jhnns I run into this while trying to use hapijs/joi:

WARNING in (webpack)/~/node-libs-browser/~/crypto-browserify/rng.js
Critical dependencies:
4:17-27 the request of a dependency is an expression
 @ (webpack)/~/node-libs-browser/~/crypto-browserify/rng.js 4:17-27

WARNING in (webpack)/~/node-libs-browser/~/crypto-browserify/LICENSE
Module parse failed: c:\Users\karan_001\code\WFMgmtApp\server\node_modules\webpa
ck\node_modules\node-libs-browser\node_modules\crypto-browserify\LICENSE Line 1:
 Unexpected identifier
You may need an appropriate loader to handle this file type.
| The MIT License
|
| Copyright (c) 2013 Dominic Tarr
 @ (webpack)/~/node-libs-browser/~/crypto-browserify ^\.\/.*$

WARNING in (webpack)/~/node-libs-browser/~/crypto-browserify/readme.markdown
Module parse failed: c:\Users\karan_001\code\WFMgmtApp\server\node_modules\webpa
ck\node_modules\node-libs-browser\node_modules\crypto-browserify\readme.markdown
 Line 1: Unexpected token ILLEGAL
You may need an appropriate loader to handle this file type.
| # crypto-browserify
|
| A (partial) port of node's `crypto` module to the browser.
 @ (webpack)/~/node-libs-browser/~/crypto-browserify ^\.\/.*$

WARNING in (webpack)/~/node-libs-browser/~/crypto-browserify/example/index.html
Module parse failed: c:\Users\karan_001\code\WFMgmtApp\server\node_modules\webpa
ck\node_modules\node-libs-browser\node_modules\crypto-browserify\example\index.h
tml Line 1: Unexpected token <
You may need an appropriate loader to handle this file type.
| <!doctype html>
| <html>
| <script src=bundle.js></script>
 @ (webpack)/~/node-libs-browser/~/crypto-browserify ^\.\/.*$

ERROR in ./~/joi/lib/string.js
Module not found: Error: Cannot resolve module 'net' in c:\Users\karan_001\code\
WFMgmtApp\server\node_modules\joi\lib
 @ ./~/joi/lib/string.js 3:10-24
// truncated

@sokra
Copy link
Member

sokra commented Oct 8, 2014

@dominictarr I'll send a PR tomorrow.

@jhnns
Copy link
Member Author

jhnns commented Oct 9, 2014

@kbdaitch and all the others: Installing [email protected] solves the problem temporarily.

sokra added a commit to sokra/crypto-browserify that referenced this issue Oct 9, 2014
@sokra
Copy link
Member

sokra commented Oct 9, 2014

fixed

@sokra sokra closed this as completed Oct 9, 2014
@timcash
Copy link

timcash commented Mar 14, 2015

I am having this problem with "crypto-browserify": "^3.9.13", and webpack 1.7.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants