Skip to content
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Add EventEmitter "removeListener" event #6

Closed
justmoon opened this issue Mar 11, 2013 · 3 comments
Closed

Add EventEmitter "removeListener" event #6

justmoon opened this issue Mar 11, 2013 · 3 comments

Comments

@justmoon
Copy link

When an event listener is removed the EventEmitter class should fire the "remoteListener" event.

This was added in Node.js 0.10, see:

nodejs/node-v0.x-archive@84221fd

Please let me know if this feature is desired and if so I'll gladly provide a pull request.

@defunctzombie
Copy link
Contributor

This feature is desired. Are you currently using webpack or browserify? If you are using browserify, the core shim for events lives here:
https://github.com/shtylman/node-browser-resolve/blob/master/builtin/events.js

In the short future, it will live in a separate module and this module will just bring the various modules together and browser-resolve will no longer be responsible for the shims.

@justmoon
Copy link
Author

Oh hai, a familiar face. :)

Are you currently using webpack or browserify?

Webpack, I came here from webpack/webpack@c1592df

Will have a pull request for you tomorrow.

@sokra
Copy link
Member

sokra commented Mar 12, 2013

It should have all features from the stable node core lib public API. 😄 But that's still a long way...

@sokra sokra closed this as completed Mar 18, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants