This repository was archived by the owner on Nov 27, 2018. It is now read-only.
Use Scala reflection api instead of scalap (2.11) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a number of reasons to prefer the Scala reflection api over scalap for type analysis. Here are a few: * Not an internal api * No transitive dependency on scala-compiler.jar * More user-friendly (It's still pretty prickly, but, of the two, it's better)
|
I realized that my changes broke serialization of tagged types in certain cases. I fixed this and added tests to prevent the issue from recurring. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 2.11-requiring version of #23. It has JacksMapper use TypeTags instead of Manifests and does not require jacks-managed locking for reflection. Due to the fact that it adds a hard dependency on Scala 2.11, I'd expect that this can't become the only branch for jacks, but I'd think that there's an outside possibility that you want to have this version and the one from #23 (or your current scalap-based version) evolve in parallel.