Add a new <slot> element for shadow trees #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd appreciate review from @zcorpan and @hayatoito and of course everyone else willing to take a look. |
annevk
added
normative change
addition/proposal
|
This will impact #1069; whichever lands first needs to be rebased on top of the other. |
|
I can wait and add |
|
Right yeah. But this might be ready to land first; I'm OK either way. |
| method, when invoked, must run these steps:</p> | ||
|
|
||
| <ol> | ||
| <li><p>If <var>options</var>'s <code data-x="">flatten</code> false, return this element's |
There was a problem hiding this comment.
missing "is" before false.
Previously we've used the phrasing "If the value of options's flatten member is false". That's kind of long but maybe do that for consistency.
Also, missing "then" ;)
|
Looks good to me. |
|
I addressed the feedback and made it blocking on #1069 since I think that's ready to land today. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.