More explicitly associate agents and event loops #5416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
clarification
annevk
approved these changes
Mar 31, 2020
|
Oh, it seems this needs to be rebased. |
This adds a specific definition for "an agent's event loop", as opposed to "event loop" generally, and uses it where appropriate. In a few cases, this involves moving from "object's event loop" to "object's relevant agent's event loop". Note that for worker agents, event loop creation and association with the agent is explicit. For window agents there is no corresponding text. This can be settled as part of #5411.
domenic
force-pushed
the
agents-event-loop
branch
from
714bd6c to
b95c755
Compare
domenic
added a commit
that referenced
this pull request
Mar 31, 2020
Closes #5210. Closes #4339 by removing the explicit phrasing of a parallel execution environment, instead relying on the agent infrastructure. Closes #4988 by reintroducing a definition for "similar-origin window agent", separate from its creation algorithm. Like the definition of all agent types, it is now informal, just stating what globals are contained in the agent. Relocates the site-related definitions to the "Origin" section of the spec, adjacent to the "schemelessly same site" and "same site" definitions. Makes event loop creation explicit during agent creation, now that they are 1:1 per #5396 and #5416. Makes "responsible event loop" a convenience accessor, instead of one of the core algorithms of environment settings objects. This means that individual environment settings object definitions no longer need to specify how to retrieve the responsible event loop. Exposes some of the higher-level concepts here to the dev edition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a specific definition for "an agent's event loop", as opposed
to "event loop" generally, and uses it where appropriate. In a few
cases, this involves moving from "object's event loop" to "object's
relevant agent's event loop".
Note that for worker agents, event loop creation and association with
the agent is explicit. For window agents there is no corresponding text.
This can be settled as part of #5411.
/web-messaging.html ( diff )
/webappapis.html ( diff )
/window-object.html ( diff )
/workers.html ( diff )