Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin node/npm version for build workflow #1496

Merged
merged 7 commits into from
Feb 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 5 additions & 19 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ concurrency:
cancel-in-progress: true

env:
NODEJS_VERSION: "18.x"
# Testing runs out of memory without this
NODE_OPTIONS: "--max-old-space-size=4096"
PROJEN_BUMP_VERSION: "0.0.0-dev.${{ github.run_id }}.${{ github.run_attempt }}"
Expand Down Expand Up @@ -100,10 +99,9 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODEJS_VERSION }}
# Reads versions from root package.json "volta" section
- name: Setup Node/NPM with pinned Volta version
uses: volta-cli/[email protected]

- name: Install Rust
uses: actions-rs/toolchain@v1
Expand All @@ -121,21 +119,14 @@ jobs:
- name: Lint Nx
run: npx nx workspace-lint

- name: Build and Unit Test
- name: Build, Test, and Package
uses: MansaGroup/nrwl-nx-action@v2
with:
targets: "build"
targets: "build,test,package"
all: true
# Exclude E2E testing
args: "--exclude=hangar --configuration=release --output-style=stream --verbose"

- name: Create NPM packages
uses: MansaGroup/nrwl-nx-action@v2
with:
targets: "package"
projects: "winglang,sdk"
args: "--configuration=release --output-style=stream --verbose"

- name: Upload Wing CLI
uses: actions/upload-artifact@v2
with:
Expand Down Expand Up @@ -230,11 +221,6 @@ jobs:
- name: Download Build Artifacts
uses: actions/download-artifact@v2

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODEJS_VERSION }}

- name: Tag commit
uses: tvdias/[email protected]
if: ${{ needs.prepare.outputs.last-version != needs.prepare.outputs.version }}
Expand Down
2 changes: 1 addition & 1 deletion apps/jsii-docgen/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"executor": "nx:run-script",
"options": {
"cwd": "apps/jsii-docgen",
"script": "build"
"script": "compile"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion apps/wing-api-checker/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"executor": "nx:run-script",
"options": {
"cwd": "apps/wing-api-checker",
"script": "build"
"script": "compile"
}
}
}
Expand Down
1 change: 1 addition & 0 deletions apps/wing-playground/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@
"contributors:check": "all-contributors check",
"contributors:generate": "all-contributors generate",
"docs": "./scripts/docsite.sh",
"install:hangar": "npm --prefix tools/hangar install",
"install:jsii-docgen": "npm --prefix apps/jsii-docgen install",
"install:sdk": "npm --prefix libs/wingsdk install",
"install:tree-sitter-wing": "npm --prefix libs/tree-sitter-wing install",
"install:vscode-wing": "npm --prefix apps/vscode-wing install",
"install:hangar": "npm --prefix tools/hangar --install-links=false install",
"install:jsii-docgen": "npm --prefix apps/jsii-docgen --install-links=false install",
"install:sdk": "npm --prefix libs/wingsdk --install-links=false install",
"install:tree-sitter-wing": "npm --prefix libs/tree-sitter-wing --install-links=false install",
"install:vscode-wing": "npm --prefix apps/vscode-wing --install-links=false install",
"install:wasi": "bash scripts/setup_wasi.sh",
"install:wing-api-checker": "npm --prefix apps/wing-api-checker install",
"install:wing-playground": "npm --prefix apps/wing-playground install",
"install:winglang": "npm --prefix apps/wing install",
"install:wing-api-checker": "npm --prefix apps/wing-api-checker --install-links=false install",
"install:wing-playground": "npm --prefix apps/wing-playground --install-links=false install",
"install:winglang": "npm --prefix apps/wing --install-links=false install",
"nx": "nx",
"postinstall": "run-p -l --max-parallel 3 'install:*'",
"test": "nx run-many --target=test --all=true"
Expand Down