Update getMetrics types #10
Open
+47
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woubuc
requested changes
Mar 22, 2020
| let url = endpoint | ||
| import { APIKey } from '../types'; | ||
|
|
||
| export const formatUrl = (apiKey : APIKey, endpoint : string[], query : Record<string, any> = {}) : string => { |
There was a problem hiding this comment.
Is there a particular reason you made this an arrow function? If not, I think it would be clearer if you change this back to a regular function notation.
There was a problem hiding this comment.
All other functions I've changed are arrow functions, so this would make it consistent
| import { formatUrl } from '../utils/url'; | ||
| import { handleResponse } from '../utils/handleResponse'; | ||
|
|
||
|
|
||
| export interface GetMetricsOptions { | ||
| export type GetMetricsOptions<Group extends MetricsGroup> = { |
There was a problem hiding this comment.
This is an object notation, so why should this be a type rather than an interface?
There was a problem hiding this comment.
I think using a consistent use of type (see other types) would be better
MichaelDeBoey
force-pushed
the
update-getMetrics-types
branch
from
4733667 to
5db6348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9 (comment), I've updated the types of
getMetrics