GH-366 Update iOS DeviceInfo.Model to return specific hw.machine

[jamesmontemagno]

via:
https://github.com/xamarin/xamarin-macios/blob/bc492585d137d8c3d3a2ffc827db3cdaae3cc869/tests/linker/ios/link%20sdk/LinkSdkRegressionTest.cs#L603-L631

Added tests

Description of Change

Describe your changes here.

Bugs Fixed

• Related to issue DeviceInfo.Model on iOS #366

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

None

Behavioral Changes

Instead of just returning iPhone/iPad will return model number such as iPad6,3

PR Checklist

• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of master at time of PR
• Changes adhere to coding standard
• Updated documentation (see walkthrough)

[dend]

✅ Validation status: passed

File	Status	Preview URL	Details
DeviceTests/DeviceTests.Shared/DeviceInfo_Tests.cs	✅Succeeded
Xamarin.Essentials/DeviceInfo/DeviceInfo.ios.cs	✅Succeeded
Xamarin.Essentials/Platform/Platform.ios.cs	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

[dend]

✅ Validation status: passed

File	Status	Preview URL	Details
DeviceTests/DeviceTests.Shared/DeviceInfo_Tests.cs	✅Succeeded
Xamarin.Essentials/DeviceInfo/DeviceInfo.ios.cs	✅Succeeded
Xamarin.Essentials/Platform/Platform.ios.cs	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

[stefandevo]

@jamesmontemagno thanks for this.
Please have a look at a maintained list of hardware identifiers:
https://github.com/fieldnotescommunities/ios-device-identifiers
This way you can map iPhone10,6 to iPhone X
If you want I can do the mapping in code.

[Redth]

@stefandevo I'm a little concerned that if we add this kind of mapping, it becomes a bit of a pain to maintain and is more likely to be forgotten. I'm leaning towards developers should just detect the actual hardware id, and not provide any sort of mapping. I'm only a bit torn because it certainly is more convenient to have the mapping.

@jamesmontemagno thoughts?

[stefandevo]

Understand the concern, but EVERYONE will start using an extra nuget package for this mapping, because the hardware_id itself will nobody use; for Android you get a clean model name, so would expect the same for Apple devices; and of course you have to maintain it, but hey, it's opensource here so you have followers enough to just add these couple of mappings per year (if they bring new devices). :-)

[Redth]

@stefandevo for now we are going to leave this out. I appreciate the concern around this, but one of the guiding principles we follow with this lib is to start out simple and not overcomplicate the API before we see enough demand.

There's also the issue of providing BOTH id's, and how that translates across platforms, or do we make a platform specific API for it, etc.

I'm sure some users will be bothered by not having the mappings, but it's pretty trivial in reality to figure out which ID you need for example for the iPhone X. We'll start without this, and if there's enough demand for it, revisit the issue at that point.

[stefandevo]

If you ever want to include the "PrettyModel" you are invited to use:
https://github.com/CaveBirdLabs/CaveBirdLabs.Xamarin.Essentials/blob/master/src/DeviceInfo.ios.extension.cs
I will keep this up to date; other devs can use the package if they want to Pretty-fy the model name