remove distutils #463
Merged
remove distutils #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #463 +/- ##
=======================================
Coverage 86.34% 86.34%
=======================================
Files 22 22
Lines 4188 4188
Branches 214 214
=======================================
Hits 3616 3616
Misses 514 514
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Cool thanks! I copied that from xarray, so if you could change it there, that would be great too! |
Will do. The sooner we get rid of distutils the better, or we will see tons of dumb breakages when moving to Python 3.12. |
|
Looks like someone already implemented the necessary changes in xarray. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is imported but unused (tests passes without it). Removing this import will make
cf_xarrayready to Python 3.12.Edit: Changing to packaging.version.parse is not the same thing as
LooseVersion, see https://discuss.python.org/t/add-looseversion-to-pypa/24359/6, but we should be OK b/c here b/c the packages checked all follow PEP440.