[Merged by Bors] - TY-2366 build ios prod #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
work-in-progress
Robert-Steiner
changed the base branch from
main
to
TY-2361-build-ios-in-bors-ci
Robert-Steiner
force-pushed
the
TY-2366-build-ios-prod
branch
9 times, most recently
from
13a6726 to
8261767
Compare
Robert-Steiner
force-pushed
the
TY-2361-build-ios-in-bors-ci
branch
from
f969b6d to
34e0413
Compare
Robert-Steiner
force-pushed
the
TY-2366-build-ios-prod
branch
13 times, most recently
from
37216ab to
fa4a78b
Compare
Robert-Steiner
force-pushed
the
TY-2361-build-ios-in-bors-ci
branch
from
262929a to
0bb4dcc
Compare
Robert-Steiner
force-pushed
the
TY-2366-build-ios-prod
branch
2 times, most recently
from
f353425 to
7c09138
Compare
|
Please rebase on top of #140 when merged |
bors bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
In #135 we have an error that `hyper` cannot be used together with lto. We forked hyper and removed the the configuration that wasn't allowing it. This pr points to that version. Running `RUSTFLAGS="-Ccodegen-units=1 -Clto=on -Cembed-bitcode=yes" just compile-android-local` works correctly.
Robert-Steiner
force-pushed
the
TY-2361-build-ios-in-bors-ci
branch
from
0bb4dcc to
360caff
Compare
Robert-Steiner
force-pushed
the
TY-2366-build-ios-prod
branch
from
7c09138 to
88abb5c
Compare
Robert-Steiner
force-pushed
the
TY-2361-build-ios-in-bors-ci
branch
from
360caff to
50f5451
Compare
Robert-Steiner
force-pushed
the
TY-2366-build-ios-prod
branch
2 times, most recently
from
0e5f2e4 to
135d088
Compare
works 🚀 |
github-actions
bot
added
ready-for-review
Robert-Steiner
force-pushed
the
TY-2366-build-ios-prod
branch
from
135d088 to
a7bd005
Compare
acrrd
approved these changes
Feb 15, 2022
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
Ticket: - [TY-2366] **Update:** lto error was addressed in #140 --- can't use `lto` because of: rust-lang/rust#51009 running: `RUSTFLAGS="-Ccodegen-units=1 -Clto=on -Cembed-bitcode=yes" just compile-ios-local` gives the error: ``` error: lto can only be run for executables, cdylibs and static library outputs error: could not compile `hyper` due to previous error ``` but `-Ccodegen-units=1` alone still decreases the size from 221mb to 144mb [TY-2366]: https://xainag.atlassian.net/browse/TY-2366?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
Update: lto error was addressed in #140
can't use
ltobecause of:rust-lang/rust#51009
running:
RUSTFLAGS="-Ccodegen-units=1 -Clto=on -Cembed-bitcode=yes" just compile-ios-localgives the error:
but
-Ccodegen-units=1alone still decreases the size from 221mb to 144mb