-
Notifications
You must be signed in to change notification settings - Fork 639
Adding support for miobulb001 #1973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcspr
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
BTW, this hardware is already defined as GENERIC_GU10 (#1549)
espurna/code/espurna/config/hardware.h
Lines 3438 to 3462 in bad47d0
// ----------------------------------------------------------------------------- | |
// Generic GU10 | |
// https://www.ebay.com/itm/1-10PC-GU10-RGB-Smart-Bulb-Wireless-WiFi-App-Remote-Ctrl-Light-for-Alexa-Google/173724116351 | |
// ----------------------------------------------------------------------------- | |
#elif defined(GENERIC_GU10) | |
// Info | |
#define MANUFACTURER "GENERIC" | |
#define DEVICE "GU10" | |
#define RELAY_PROVIDER RELAY_PROVIDER_LIGHT | |
#define LIGHT_PROVIDER LIGHT_PROVIDER_DIMMER | |
#define DUMMY_RELAY_COUNT 1 | |
// Light | |
#define LIGHT_CHANNELS 4 | |
#define LIGHT_CH1_PIN 14 // RED | |
#define LIGHT_CH2_PIN 12 // GREEN | |
#define LIGHT_CH3_PIN 13 // BLUE | |
#define LIGHT_CH4_PIN 4 // WHITE | |
#define LIGHT_CH1_INVERSE 0 | |
#define LIGHT_CH2_INVERSE 0 | |
#define LIGHT_CH3_INVERSE 0 | |
#define LIGHT_CH4_INVERSE 0 | |
(I need to take some time to auto-detect these duplicates in the future...)
revert default env use dashes
I just fixed typos from 80632d1 myself, sorry not mentioning this earlier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for miobulb001
https://www.amazon.es/Muvit-MIOBULB001-Inteligente-Compatible-asistentes/dp/B07KMWZ41R