Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package version is 1.x, even though API is *not* stable #65

Closed
crumblingstatue opened this issue Mar 23, 2016 · 11 comments
Closed

Package version is 1.x, even though API is *not* stable #65

crumblingstatue opened this issue Mar 23, 2016 · 11 comments

Comments

@crumblingstatue
Copy link
Contributor

In #60, the version was bumped to 1.0.0. This was a mistake, as our API is still unstable. At the very least, we depend on an unstable sdl2 crate, so every time we update our sdl2 dependency, it's a breaking change.

This means that we would have to increment the major version (i.e. 2.0.0, 3.0.0, ...) after every sdl2 upgrade.

I'm not sure if this can be fixed (either by yanking, or by special request, deleting for good our 1.x versions from crates.io), or if we are stuck having to upgrade the major version every time we make a breaking change.

@andelf
Copy link
Collaborator

andelf commented Mar 23, 2016

crates.io supports yank. cargo yank
sdl2_mixer, sdl2_ttf use same version string as sdl2.
@xsleonard

@xsleonard
Copy link
Owner

@andelf are you able to admin the package on crates.io?

@andelf
Copy link
Collaborator

andelf commented Mar 24, 2016

@xsleonard yes.
yanking 1.x will break following repos. :(
serarch result

Better to inform them before we do this yanking.

@andelf
Copy link
Collaborator

andelf commented Mar 24, 2016

I'll yank v1.1.0 and v1.0.0.

@andelf andelf closed this as completed in 9e01f46 Mar 24, 2016
@crumblingstatue
Copy link
Contributor Author

@andelf Is it actually possible to start releasing lower versions than the ones we already published, even if we yank them? I'm concerned.

@andelf
Copy link
Collaborator

andelf commented Mar 24, 2016

@crumblingstatue

The semantics of a yanked version are that no new dependencies can be created against that version, but all existing dependencies continue to work.

@andelf andelf reopened this Mar 24, 2016
@andelf
Copy link
Collaborator

andelf commented Mar 24, 2016

I've published v0.16.0.

but our crates.io homepage shows:

This crate has been yanked, but it is still available for download for other crates that may be depending on it.

It only displays newest version of the create by default. :(

should we make a feature request to creates.io?

andelf added a commit that referenced this issue Mar 24, 2016
@andelf
Copy link
Collaborator

andelf commented Mar 24, 2016

refer: rust-lang/crates.io#76

@andelf
Copy link
Collaborator

andelf commented Mar 24, 2016

😂 Should we publish a new v1.1.1? Currently our crates.io page is completely gone.

@crumblingstatue
Copy link
Contributor Author

Should we publish a new v1.1.1?

That would only make the situation even more confusing. We caused enough mess as it is already.

@crumblingstatue
Copy link
Contributor Author

Closing, since this crate is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants