Preserve collection order of dimensions, dimension fields and metrics #25
Conversation
archolewa
force-pushed
the
TracingOrderChangeBug
branch
from
4fc4161 to
9bf4346
Compare
|
👍 |
|
Changelog needed, since this changes some method signatures. |
archolewa
force-pushed
the
TracingOrderChangeBug
branch
from
9bf4346 to
535e4fc
Compare
| @@ -46,7 +47,7 @@ public static Response makeJobMetadataResponse(String jobMetadata) { | |||
| * @return A PreResponse containing the error information that should be sent to the user | |||
| */ | |||
| public static PreResponse buildErrorPreResponse(Throwable throwable) { | |||
| ResponseContext responseContext = new ResponseContext(Collections.emptyMap()); | |||
| ResponseContext responseContext = new ResponseContext(new LinkedHashMap<>()); | |||
There was a problem hiding this comment.
Rather than make a new object each time, it would be good if we could only create 1 object and just re-use that over and over (like what Collections.emptyMap() did).
There was a problem hiding this comment.
That sounds dangerous to me, unless we take steps to make sure the empty map is immutable. The reason Collections.emptyMap is safe is because it's immutable, so you don't have to worry about someone accidentally modifying the map and spreading the changes all over the system.
Frankly, the overhead of building an empty collection is so tiny that I doubt creating our own custom empty, immutable LinkedHashMapis worth the effort.
archolewa
force-pushed
the
TracingOrderChangeBug
branch
from
535e4fc to
873553f
Compare
|
👍 |
No description provided.