Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timing from JobsApiRequestSpec #27

Closed
wants to merge 0 commits into from

Conversation

archolewa
Copy link
Contributor

@archolewa archolewa commented Aug 31, 2016

-- The spec has test that verifies that when the timeout expires, an
empty Observable is emitted. However, the timeout was 2 milliseconds,
and the main test thread was only sleeping 5 milliseconds before sending
the message. These two times were too close together, so that the test
may result in a false failure in a highly contested environment (i.e.
Travis). So the test was rewritten so that it doesn't rely on any timing.

@cdeszaq
Copy link
Collaborator

cdeszaq commented Aug 31, 2016

👍

@archolewa archolewa force-pushed the JobsApiRequestSpec-better-timing-buffer branch from 65b9d83 to 89f5a26 Compare August 31, 2016 17:25
@archolewa archolewa changed the title Adds more timing buffers to JobsApiRequestSpec Remove timing from JobsApiRequestSpec Aug 31, 2016
@michael-mclawhorn
Copy link
Contributor

You say you increased the sleep time, but I don't see that change.

@michael-mclawhorn
Copy link
Contributor

Needs changelog.

@archolewa
Copy link
Contributor Author

archolewa commented Aug 31, 2016

@michael-mclawhorn You were seeing a slightly out of date description for the PR. Originally I was just increasing the buffer for the timing, but then I realized that we could test what we wanted to test without worrying about any timing at all (besides the standard timeout timing we see on many tests). I made that change, but forgot at first to update the name of the PR.

@michael-mclawhorn
Copy link
Contributor

Makes sense.
👍

@archolewa archolewa force-pushed the JobsApiRequestSpec-better-timing-buffer branch from 24867ea to c53504b Compare August 31, 2016 19:24
@cdeszaq cdeszaq closed this Aug 31, 2016
@cdeszaq cdeszaq force-pushed the JobsApiRequestSpec-better-timing-buffer branch from c53504b to b8a57a8 Compare August 31, 2016 19:52
@archolewa archolewa deleted the JobsApiRequestSpec-better-timing-buffer branch August 31, 2016 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants