Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return deno env object #432

Merged
merged 4 commits into from
Feb 27, 2022
Merged

fix: return deno env object #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b07356b
fix: return deno env object
johanholmerin Jan 25, 2022
9877c40
test: add test for deno envPrefix
hugojosefson Feb 25, 2022
09ab9ef
Merge branch 'main' into patch-1
bcoe Feb 26, 2022
4165f3c
test: fix deno env tests
johanholmerin Feb 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ jobs:
deno-version: v1.x
- run: |
deno --version
deno test --allow-read test/deno/yargs-test.ts
deno test --allow-read --allow-env test/deno/yargs-test.ts
env:
MY_PREFIX_MY_KEY: "my value"
browser:
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion deno.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import type { Arguments, ArgsInput, Parser, Options, DetailedArguments } from '.
const parser = new YargsParser({
cwd: Deno.cwd,
env: () => {
Deno.env.toObject()
return Deno.env.toObject()
},
format: (str: string, arg: string) => { return str.replace('%s', arg) },
normalize: path.posix.normalize,
Expand Down
5 changes: 5 additions & 0 deletions test/deno/yargs-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,8 @@ Deno.test('it detects strings that could be parsed as numbers', () => {
assertEquals(parser.looksLikeNumber('0100'), false)
assertEquals(parser.looksLikeNumber('apple'), false)
})

Deno.test('should load values from environment variables', () => {
const argv = parser([], { envPrefix: 'MY_PREFIX_' })
assertEquals(argv.myKey, 'my value')
})