fix(fslib): don't destroy createReadStream in ZipFS before it finishes #2159
+189
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
commented
Nov 22, 2020
Comment on lines
-512
to
+513
| expect(() => iter.next()).rejects.toThrow(`Directory handle was closed`); | ||
| // FIXME: This assertion fails | ||
| // await expect(() => iter.next()).rejects.toThrow(`Directory handle was closed`); |
There was a problem hiding this comment.
This failed before this PR but wasn't awaited so it wasn't caught
arcanis
reviewed
Nov 23, 2020
arcanis
approved these changes
Nov 23, 2020
merceyz
force-pushed
the
merceyz/zipfs-readstream-close
branch
from
ef7ac79 to
49deb21
Compare
merceyz
force-pushed
the
merceyz/zipfs-readstream-close
branch
from
147ef21 to
ef79d1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
There is a race condition in the
createReadStreamimplementation inZipFS, if the file the stream is created for is large enough the stream will be destroyed before the write finishes.Fixes #2004
How did you fix it?
Avoid calling destroy on successful reads and let the
PassThroughautoDestroyitself, applied the same changes tocreateWriteStream.I also made the read async to speed it up a bit
Checklist