Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update Node.js range for extensionless files #6035

Merged
merged 2 commits into from
Jan 3, 2024
Merged

test: update Node.js range for extensionless files #6035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b8c78f
test: update Node.js range for extensionless files
merceyz Dec 23, 2023
c419886
chore: versions
merceyz Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
],
"eslint.nodePath": ".yarn/sdks",
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
"source.fixAll.eslint": "explicit"
},
"pasteImage.path": "${projectRoot}/packages/gatsby/static",
"pasteImage.basePath": "${projectRoot}/packages/gatsby/static",
Expand Down
2 changes: 2 additions & 0 deletions .yarn/versions/0fefb43f.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
declined:
- "@yarnpkg/pnp"
18 changes: 7 additions & 11 deletions packages/acceptance-tests/pkg-tests-specs/sources/pnp-esm.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import {nodeUtils} from '@yarnpkg/core';
import {Filename, npath, ppath, xfs} from '@yarnpkg/fslib';
import {HAS_LOADERS_AFFECTING_LOADERS} from '@yarnpkg/pnp/sources/esm-loader/loaderFlags';
import {pathToFileURL} from 'url';

const ifAtLeastNode21It = nodeUtils.major >= 21 ? it : it.skip;
const ifAtMostNode20It = nodeUtils.major <= 20 ? it : it.skip;
import {Filename, npath, ppath, xfs} from '@yarnpkg/fslib';
import {ALLOWS_EXTENSIONLESS_FILES, HAS_LOADERS_AFFECTING_LOADERS} from '@yarnpkg/pnp/sources/esm-loader/loaderFlags';
import {pathToFileURL} from 'url';

describe(`Plug'n'Play - ESM`, () => {
test(
Expand Down Expand Up @@ -404,7 +400,7 @@ describe(`Plug'n'Play - ESM`, () => {
),
);

ifAtMostNode20It(
(ALLOWS_EXTENSIONLESS_FILES ? it.skip : it)(
`it should not allow extensionless commonjs imports`,
makeTemporaryEnv(
{ },
Expand All @@ -425,7 +421,7 @@ describe(`Plug'n'Play - ESM`, () => {
),
);

ifAtLeastNode21It(
(ALLOWS_EXTENSIONLESS_FILES ? it : it.skip)(
`it should allow extensionless commonjs imports`,
makeTemporaryEnv(
{ },
Expand All @@ -445,7 +441,7 @@ describe(`Plug'n'Play - ESM`, () => {
),
);

ifAtMostNode20It(
(ALLOWS_EXTENSIONLESS_FILES ? it.skip : it)(
`it should not allow extensionless files with {"type": "module"}`,
makeTemporaryEnv(
{
Expand All @@ -467,7 +463,7 @@ describe(`Plug'n'Play - ESM`, () => {
),
);

ifAtLeastNode21It(
(ALLOWS_EXTENSIONLESS_FILES ? it : it.skip)(
`it should allow extensionless files with {"type": "module"}`,
makeTemporaryEnv(
{
Expand Down
3 changes: 3 additions & 0 deletions packages/yarnpkg-pnp/sources/esm-loader/loaderFlags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,6 @@ export const HAS_LAZY_LOADED_TRANSLATORS = (major === 20 && minor < 6) || (major
// https://github.com/nodejs/node/pull/43772
// TODO: Update the version range if it gets backported to v18.
export const HAS_LOADERS_AFFECTING_LOADERS = major > 19 || (major === 19 && minor >= 6);

// https://github.com/nodejs/node/pull/49869
export const ALLOWS_EXTENSIONLESS_FILES = major >= 21 || (major === 20 && minor >= 10) || (major === 18 && minor >= 19);