Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bring back the aggressive concurrency protection #4573

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Conversation

BYK
Copy link
Member

@BYK BYK commented Sep 28, 2017

Summary

Follow up to #4486 which reverted the while loop that waits on
potential multiple copies of the same file. This seems to have
some random breakages and needs more investigation for optimizing.

Test plan

N/A

**Summary**

Follow up to #4486 which reverted the while loop that waits on
potential multiple copies of the same file. This seems to have
some random breakages and needs more investigation for optimizing.

**Test plan**

N/A
@BYK BYK requested a review from arcanis September 28, 2017 15:07
@buildsize
Copy link

buildsize bot commented Sep 28, 2017

This change will increase the build size from 9.83 MB to 9.83 MB, an increase of 315 bytes (0%)

File name Previous Size New Size Change
yarn-[version].noarch.rpm 848.17 KB 848.11 KB -59 bytes (0%)
yarn-[version].js 3.74 MB 3.74 MB 199 bytes (0%)
yarn-legacy-[version].js 3.79 MB 3.79 MB 199 bytes (0%)
yarn-v[version].tar.gz 853.8 KB 853.79 KB -10 bytes (0%)
yarn_[version]all.deb 645.11 KB 645.1 KB -14 bytes (0%)

@BYK BYK merged commit 3b0bcc0 into master Sep 28, 2017
@BYK BYK deleted the concurrency branch September 28, 2017 15:55
joaolucasl pushed a commit to joaolucasl/yarn that referenced this pull request Oct 27, 2017
**Summary**

Follow up to yarnpkg#4486 which reverted the while loop that waits on
potential multiple copies of the same file. This seems to have
some random breakages and needs more investigation for optimizing.

**Test plan**

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants