Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an issue with default values #15862

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

gridnevvvit
Copy link
Member

@gridnevvvit gridnevvvit commented Mar 17, 2025

Changelog entry

fix an issue with default values: precompute lookup may not contain all required columns in input

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@gridnevvvit gridnevvvit requested a review from a team as a code owner March 17, 2025 21:30
Copy link

github-actions bot commented Mar 17, 2025

🟢 2025-03-18 08:27:36 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 21:34:14 UTC Pre-commit check linux-x86_64-release-asan for dab4274 has started.
2025-03-17 21:34:45 UTC Artifacts will be uploaded here
2025-03-17 21:37:56 UTC ya make is running...
🟡 2025-03-17 22:33:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11941 11873 0 15 15 38

2025-03-17 22:34:55 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-17 22:46:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 60 0 2 6 34

2025-03-17 22:46:38 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-17 23:09:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 32 0 0 5 32

🟢 2025-03-17 23:09:37 UTC Build successful.
🟢 2025-03-17 23:10:04 UTC ydbd size 3.8 GiB changed* by -7.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a0ceb34 merge: dab4274 diff diff %
ydbd size 4 047 169 640 Bytes 4 047 162 136 Bytes -7.3 KiB -0.000%
ydbd stripped size 1 400 234 440 Bytes 1 400 232 968 Bytes -1.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 21:34:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for dab4274 has started.
2025-03-17 21:34:33 UTC Artifacts will be uploaded here
2025-03-17 21:37:17 UTC ya make is running...
🟡 2025-03-17 22:29:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19220 17874 0 4 1229 113

2025-03-17 22:31:11 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-17 22:48:32 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
169 (only retried tests) 58 0 0 3 108

🟢 2025-03-17 22:48:39 UTC Build successful.
🟢 2025-03-17 22:48:57 UTC ydbd size 2.1 GiB changed* by -2.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a0ceb34 merge: dab4274 diff diff %
ydbd size 2 298 537 488 Bytes 2 298 534 800 Bytes -2.6 KiB -0.000%
ydbd stripped size 481 147 840 Bytes 481 147 520 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit merged commit 31b3314 into ydb-platform:main Mar 18, 2025
16 checks passed
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Mar 19, 2025
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Mar 19, 2025
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Emgariko pushed a commit to Emgariko/ydb that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants