Clarifying the cause of the error after an authentication attempt #17012
Conversation
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
flown4qqqq
requested review from
CyberROFL and
ijon
and removed request for
CyberROFL
ydb/library/login/login.cpp
Outdated
| if (!sid.IsEnabled) { | ||
| response.Error = TStringBuilder() << "User " << request.User << " is not permitted to log in, because it is blocked"; | ||
| } else { | ||
| response.Error = TStringBuilder() << "User " << request.User << " is not permitted to log in, because the count of password attempts has been exceeded"; | ||
| } |
There was a problem hiding this comment.
I would suggest making error messages more concise:
-> User {request.User} login denied: account is blocked
-> User {request.User} login denied: too many failed password attempts
There was a problem hiding this comment.
the logic was that we wanted to mimic postgres. However, with the clarification of the reason, we are no longer doing this, so your option looks more successful.
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
The pull request is aimed at clarifying the reason why the user could not log in.
Changelog category