Fix the Unicode issue for all connection code paths #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6b7ac4 does not seem to set the text_factory property on the correct object, nor is it comprehensive for all code paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into the issue that was supposed to be resolved by #49, but it didn't work. Dug into it a little more and it looks like the
text_factoryproperty was getting set on the sqlalchemy connection rather than the raw, sqlite connection.#49 also missed the code path where
persist=True, since that connection is set up elsewhere.Updated the code to use a connection listener (only for sqlite...have not tested the postgres use case, so just avoiding it to prevent issues) to make sure that
text_factoryis set no matter where the connection is made.Tried to verify that the tests still pass, but was already getting a lot of failures before my change, all of this nature: