disallow old array() syntax #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may have long array syntax at some places. For example: |
|
You could add codingStandardsIgnore tags to code that needs it. The rest should be fixed. |
|
I've added an exclude pattern to ignore the entire requirements directory, and removed the two separate ones. |
|
Well? |
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Yii2 uses the short array syntax, I wrote this sniff to catch accidental use of array().
I checked the framework source, and it found a couple files, mostly translation files and requirements.php (I guess that one has to stay so that it can run on older php, so it can be added to exclusions).