Prepare Chapter14 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokomotod
force-pushed
the
prepare-ch14
branch
from
67ae666 to
5c81674
Compare
yokomotod
force-pushed
the
prepare-ch14
branch
from
5c81674 to
f3a0f3f
Compare
yokomotod
requested review from
ma2gedev,
takumikid,
hiro-o918,
kitagry,
inakam,
marutaku,
NagayamaRyoga and
adieumonks
hiro-o918
reviewed
Sep 18, 2024
simpledb/buffer/buffer.go
Outdated
| buff := bm.findExistingBuffer(blk) | ||
| blockAccessed := 0 |
There was a problem hiding this comment.
[ask] enum かと思ったんですが、これは単にアクセスすうですか？
There was a problem hiding this comment.
@hiro-o918 です。
StatInfo.BlocksAccessed() とかに合わせたつもりだったんですが block*s*Accessed になってなかったので修正しました 89d4ee1
| return 0, fmt.Errorf("vals2 has no key %s", fieldName) | ||
| } | ||
|
|
||
| if !val1.Equals(val2) { |
There was a problem hiding this comment.
[ask]
これは最初に equals じゃなくなったもので sort するということです？
There was a problem hiding this comment.
sortではなく大小比較ですね。（この関数を使ってsortするのはそう） rc.Fields の複数キーでの比較で、スライスの順序＝比較優先順
もともとの Compare() と同様（27行目
yokomotod
force-pushed
the
prepare-ch14
branch
from
f3a0f3f to
0fc79c0
Compare
yokomotod
force-pushed
the
prepare-ch14
branch
from
0fc79c0 to
89d4ee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
14章の差分のまえのいろいろ
int=>int32変更