This repository was archived by the owner on May 1, 2021. It is now read-only.
Problem: usage of intertrait crate #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently using [intertrait](https://crates.io/crates/intertrait), which depends on [linkme](https://crates.io/crates/linkme). While it works on Linux, macOS and Windows, it might not work elsewhere as it's platform-dependent. In fact, there's no support for WebAssembly: dtolnay/linkme#6 and that's one of the goals for BPXE. Solution: roll our own `Cast` trait It's a bit crude and is certainly less ergonomic (compared to `intertrait`) but it seems to work. The idea is to make `DocumentElement` trait implement `Cast<T>` where `T` is all `Type` and `TypeMut` traits and then auto-generate implementations of this `Cast<T>` trait for every struct and enum. One downside of this approach is that `autogenerated.rs` is much bigger now (approaching 7Mb). That being said, it might eventually be generated during build-time and we won't have to distribute it as is. I suppose the amount of actual code generated by trait casting crates is effectively of a similar size. Closes #8
yrashk
added a commit
that referenced
this pull request
Jan 26, 2021
As of #10, it *should* be able to compile, but we don't know that for a fact. Solution: instrument Cargo.tomls to be able to build for WebAssembly Firstly, had to reduce the scope of features for Tokio (that's a good thing to do, anyway) to make it able to compile for WebAssembly (networking and other I/O is a no-go). Secondly, had to add `cdylib` crate type. At this point, I was not yet able to run tests, but at the very least we can check that it *builds* and I've added a "wasm" job to GitHub Actions workflows to check for that as well.
yrashk
added a commit
that referenced
this pull request
Jan 26, 2021
As of #10, it *should* be able to compile, but we don't know that for a fact. Solution: instrument Cargo.tomls to be able to build for WebAssembly Firstly, had to reduce the scope of features for Tokio (that's a good thing to do, anyway) to make it able to compile for WebAssembly (networking and other I/O is a no-go). Secondly, had to add `cdylib` crate type. At this point, I was not yet able to run tests, but at the very least we can check that it *builds* and I've added a "wasm" job to GitHub Actions workflows to check for that as well.
yrashk
added a commit
that referenced
this pull request
Jan 26, 2021
As of #10, it *should* be able to compile, but we don't know that for a fact. Solution: instrument Cargo.tomls to be able to build for WebAssembly Firstly, had to reduce the scope of features for Tokio (that's a good thing to do, anyway) to make it able to compile for WebAssembly (networking and other I/O is a no-go). Secondly, had to add `cdylib` crate type. At this point, I was not yet able to run tests, but at the very least we can check that it *builds* and I've added a "wasm" job to GitHub Actions workflows to check for that as well.
yrashk
added a commit
that referenced
this pull request
Jan 26, 2021
As of #10, it *should* be able to compile, but we don't know that for a fact. Solution: instrument Cargo.tomls to be able to build for WebAssembly Firstly, had to reduce the scope of features for Tokio (that's a good thing to do, anyway) to make it able to compile for WebAssembly (networking and other I/O is a no-go). Secondly, had to add `cdylib` crate type. At this point, I was not yet able to run tests, but at the very least we can check that it *builds* and I've added a "wasm" job to GitHub Actions workflows to check for that as well.
yrashk
added a commit
that referenced
this pull request
Jan 26, 2021
As of #10, it *should* be able to compile, but we don't know that for a fact. Solution: instrument Cargo.tomls to be able to build for WebAssembly Firstly, had to reduce the scope of features for Tokio (that's a good thing to do, anyway) to make it able to compile for WebAssembly (networking and other I/O is a no-go). Secondly, had to add `cdylib` crate type. At this point, I was not yet able to run tests, but at the very least we can check that it *builds* and I've added a "wasm" job to GitHub Actions workflows to check for that as well.
yrashk
added a commit
that referenced
this pull request
Jan 26, 2021
As of #10, it *should* be able to compile, but we don't know that for a fact. Solution: instrument Cargo.tomls to be able to build for WebAssembly Firstly, had to reduce the scope of features for Tokio (that's a good thing to do, anyway) to make it able to compile for WebAssembly (networking and other I/O is a no-go). Secondly, had to add `cdylib` crate type. At this point, I was not yet able to run tests, but at the very least we can check that it *builds* and I've added a "wasm" job to GitHub Actions workflows to check for that as well.
yrashk
added a commit
that referenced
this pull request
Jan 26, 2021
As of #10, it *should* be able to compile, but we don't know that for a fact. Solution: instrument Cargo.tomls to be able to build for WebAssembly Firstly, had to reduce the scope of features for Tokio (that's a good thing to do, anyway) to make it able to compile for WebAssembly (networking and other I/O is a no-go). Secondly, had to add `cdylib` crate type. At this point, I was not yet able to run tests, but at the very least we can check that it *builds* and I've added a "wasm" job to GitHub Actions workflows to check for that as well.
yrashk
added a commit
that referenced
this pull request
Jan 26, 2021
As of #10, it *should* be able to compile, but we don't know that for a fact. Solution: instrument Cargo.tomls to be able to build for WebAssembly Firstly, had to reduce the scope of features for Tokio (that's a good thing to do, anyway) to make it able to compile for WebAssembly (networking and other I/O is a no-go). Secondly, had to add `cdylib` crate type. At this point, I was not yet able to run tests, but at the very least we can check that it *builds* and I've added a "wasm" job to GitHub Actions workflows to check for that as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently using intertrait, which depends on linkme. While it works on Linux, macOS and Windows, it might not work elsewhere as it's platform-dependent.
In fact, there's no support for WebAssembly: dtolnay/linkme#6 and that's one of the goals for BPXE.
Solution: roll our own
CasttraitIt's a bit crude and is certainly less ergonomic (compared to
intertrait) but it seems to work.The idea is to make
DocumentElementtrait implementCast<T>whereTis allTypeandTypeMuttraits and then auto-generate implementations of thisCast<T>trait for every struct and enum.One downside of this approach is that
autogenerated.rsis much bigger now (approaching 7Mb). That being said, it might eventually be generated during build-time and we won't have to distribute it as is. I suppose the amount of actual code generated by trait casting crates is effectively of a similar size.Closes #8