Skip to content
This repository was archived by the owner on Apr 10, 2021. It is now read-only.

Consider allowing any HTTP method #35

Closed
Ohmnivore opened this issue Jan 7, 2017 · 2 comments
Closed

Consider allowing any HTTP method #35

Ohmnivore opened this issue Jan 7, 2017 · 2 comments
Assignees
Milestone

Comments

@Ohmnivore
Copy link

Browsing through the source, I can see that at its core the method is just a String value. Yet, the library restricts it to the usual four REST methods. In my use-case I only need to use a PATCH request, but there's so many other methods in the wild that I don't think it makes sense to artificially restrict them.

yupswing pushed a commit that referenced this issue Jan 9, 2017
@yupswing
Copy link
Owner

yupswing commented Jan 9, 2017

I agree with you completely. Actually I've just updated the library to v0.4.7 to comply with your request.

You have to understand that the javascript target accept only GET and POST (it is an haxe.Http limitation). At the beginning of the library I've tried to limit a lot of stuff to have the exact same features in every target. Slowly this requirement was impossible to stand, so the library has 'mostly' the exact features on every target.
This is such a case where it is better to allow everything and to point out that one target has a limitation.

Thank you for your feedback.
PS: you can update the library directly from haxelib

@yupswing yupswing closed this as completed Jan 9, 2017
@yupswing yupswing self-assigned this Jan 9, 2017
@yupswing yupswing added this to the 0.4.x milestone Jan 9, 2017
@Ohmnivore
Copy link
Author

Awesome! Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants