nix: Fix runtime dependencies not being found #26864
Open
+3
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have @marius851000 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
Oh! It’s at the end of the page. I have to say, I do not appreciate seemingly not stricly necessary information like an email (not that it’s not in Git) or anything else than a proof it is my GitHub account, but I have more constructive thing to do than to criticize that (questionably legal under GDPR) decision. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
maxdeviant
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I’m going to follow the template for "Proposing Change". I’m not sure it’s supposed to apply to PR too, or just suggestion)
Problem statment:
The nix build does not execute on a NixOS environment, as it can’t locate the wayland runtime dependancies
The -rpath in the file does not appear to work, at it doesn’t add it to either libraries (this can be checked with
patchelf --print-rpath <elf executable>)solution proposal:
Add the LD_LIBRARY_PATH environment variable to the variable, serving the same purpose, but that work (it’s how I’m used to do that kind of stuff in NixPkgs.
Release Notes:
Other
(I’m not sure it’s important enought to mention in the changelog)
(also, where does I agree to the contributor license agreement? Do I state it here? Yes, I agree to the contributor license agreement as shown here https://zed.dev/cla as of the date of 16/03/2025 at 08:40 UTC)