Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Enable providers with custom domains #26879

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

khayyamsaleem
Copy link

  • fix(git): Add support for custom domain permalinks and provider configuration
  • create settings structure for git hosting providers

…guration

This change allows custom Git hosting providers to be configured in settings.
Adds the ability to specify custom domains for git hosting providers like
GitHub and GitLab, and enables permalink generation for repositories hosted
on custom domains.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 16, 2025
@khayyamsaleem khayyamsaleem force-pushed the bug/23103-git-custom-domain-permalinks branch from c14aaf2 to 491db54 Compare March 16, 2025 17:15
@khayyamsaleem khayyamsaleem force-pushed the bug/23103-git-custom-domain-permalinks branch from 491db54 to af8c538 Compare March 16, 2025 17:16
@khayyamsaleem
Copy link
Author

Targets to fix #23103 but could use some design input

@khayyamsaleem khayyamsaleem marked this pull request as ready for review March 16, 2025 17:22
@maxdeviant maxdeviant changed the title git: enable providers with custom domains git: Enable providers with custom domains Mar 16, 2025
@maxdeviant maxdeviant self-assigned this Mar 16, 2025
@khayyamsaleem
Copy link
Author

self-review:

  • i found myself wanting to refactor the provider_registry notion into something a bit more dynamic, like a factory pattern to create providers all with the same pattern. little less hardcoding. but opted for minimal diff in the first pass to get the idea across. would prefer the shape of the static map to be type => registry_creator as opposed to name => registry_instance, and then the registry instances would only be created on-demand when a provider-specific utility is required.
  • am i accessing the settings the right way? is it fine to access the global settings in the init?
  • are there places to document the settings options I'm choosing to add? is there a way to have them self-documented with code-gen?
  • rather than a separate top-level git_providers settings key, should this be reshaped to be a member of a git config key, with git.providers under it? though, noticed different git-related settings like git_panel already occupying separate top-level config keys, so not sure what the best pattern is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants