Add --user-data-dir CLI flag and propose renaming support_dir to data_dir #26886
+107
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new CLI flag `--user-data-dir` to allow users to specify a custom directory for Zed's data (e.g., database, extensions, logs). This is implemented by: - Adding the flag to `crates/cli/src/main.rs` and `crates/zed/src/main.rs`. - Setting `CUSTOM_DATA_DIR` via `paths::set_custom_data_dir` in both CLI and editor processes. - Passing the flag via IPC in `CliRequest::Open` for background mode consistency.
…arity Renames `support_dir` to `data_dir` to better reflect its role as the root directory for Zed's user data across all platforms. The original name was macOS-specific (aligned with "Application Support"), which felt less intuitive on Linux (~/.local/share/zed) and Windows (%LOCALAPPDATA%\Zed). This change: - Updates `crates/paths/src/paths.rs` to use `data_dir` and `DATA_DIR` static. - Adjusts dependent functions (e.g., `database_dir`, `extensions_dir`) to call `data_dir`. - Updates callers in `crates/cli/src/main.rs` and other crates as needed.
cla-bot
bot
added
the
cla-signed
Signed-off-by: Marko Kungla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for a
--user-data-dirCLI flag to override Zed's data directory and proposes renamingsupport_dirtodata_dirfor better cross-platform clarity. It builds on the discussion in #25349 about custom data directories, aiming to provide a flexible cross-platform solution.Changes
The PR is split into two commits:
Context
Inspired by the need for custom data directories discussed in #25349, this PR provides an immediate implementation in the first commit, while the second commit suggests a naming improvement for broader appeal. @mikayla-maki, I’d appreciate your feedback, especially on the rename proposal, given your involvement in the original discussion!
Testing
cargo build./target/debug/zed --user-data-dir ~/custom-data-dirRelease Notes: