Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vim.default_mode setting instead of hardcoding Mode::Normal #26887

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

illode
Copy link

@illode illode commented Mar 16, 2025

Closes #26859. Specifically, fixes this issue with:

  • vim::VisualDelete
  • vim::VisualYank
  • vim::VisualReplace
  • vim::AddSurrounds
  • vim::Paste
  • vim::Increment
  • All of the vim case changing actions
  • vim::JoinLines
  • vim::ToggleComments

Release Notes:

  • Fixed yanking, pasting, and several other actions ignoring the vim.default_mode setting.

Copy link

cla-bot bot commented Mar 16, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @illode on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@illode
Copy link
Author

illode commented Mar 16, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 16, 2025
Copy link

cla-bot bot commented Mar 16, 2025

The cla-bot has been summoned, and re-checked this pull request!

@illode
Copy link
Author

illode commented Mar 16, 2025

I'm not 100% sure that the switch_mode in temporary_normal should be changed, since it's not clear what it's purpose is. Aside from that, tested briefly and the changes seem to work without issue.

I removed the ones I wasn't sure were necessary since it seemed like one of them was causing slightly jank mode switching behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yanking and pasting in vim mode will automatically switch back to normal mode
1 participant