Update php84 #383
Merged
Update php84 #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates the PHP versions used in various GitHub workflows.
- Updated the test workflow to use a PHP version matrix including 8.1, 8.2, 8.3, and 8.4.
- Updated the PHP version in the coding-style, static-analysis, and build-release-artifacts workflows to 8.1.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/test.yml | Expanded PHP version matrix to support PHP versions 8.1–8.4 |
| .github/workflows/coding-style.yml | Updated PHP version to 8.1 for setup |
| .github/workflows/static-analysis.yml | Updated PHP version to 8.1 for setup |
| .github/workflows/build-release-artifacts.yml | Updated PHP version to 8.1 for setup |
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
.github/workflows/coding-style.yml:37
- [nitpick] The coding-style workflow is currently limited to PHP 8.1. If the project intends to support other PHP versions (like 8.2, 8.3, or 8.4), consider expanding the test coverage to catch version-specific issues.
php-version: 8.1
.github/workflows/static-analysis.yml:37
- [nitpick] The static-analysis workflow uses only PHP 8.1. Consider evaluating whether additional PHP versions need to be analyzed to ensure comprehensive compatibility.
php-version: 8.1
.github/workflows/build-release-artifacts.yml:22
- [nitpick] The build-release-artifacts workflow is configured to use PHP 8.1, while other workflows are being updated for newer PHP versions. Confirm that artifact building is compatible with these newer PHP versions if needed.
php-version: 8.1
sunxyw
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.