Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove workaround on windows which disables byval parameters #536

Closed
andrewrk opened this issue Oct 15, 2017 · 2 comments
Closed

remove workaround on windows which disables byval parameters #536

andrewrk opened this issue Oct 15, 2017 · 2 comments
Labels
bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals. os-windows upstream An issue with a third party project that Zig uses.
Milestone
0.3.0

Comments

@andrewrk
Copy link
Member

There is a bug in Windows code generation in LLVM causing tests to fail: https://bugs.llvm.org/show_bug.cgi?id=34952

Until this is fixed, I worked around the issue by disabling byval parameters. The only byval parameter is slices right now. This is not an issue until we add concurrency (see #174) in which this situation can break without byval:

  • thread 1 passes a_slice to a function
  • thread 2 reassigns a_slice
  • thread 1 expected the parameter to be constant but now it changed.

We'll need to make sure this bug is fixed and remove the workaround before adding concurrency.
@andrewrk andrewrk added bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals. labels Oct 15, 2017
@andrewrk andrewrk added this to the 0.2.0 milestone Oct 15, 2017
andrewrk added a commit that referenced this issue Oct 15, 2017
@andrewrk
disable byval parameters on windows to work around llvm bug
9c44dd7 
See #536
@andrewrk andrewrk modified the milestone: 0.2.0 Oct 19, 2017
@andrewrk andrewrk mentioned this issue Oct 24, 2017
Closed
@andrewrk andrewrk added the upstream An issue with a third party project that Zig uses. label Mar 7, 2018
@andrewrk
Copy link
Member Author

andrewrk commented Mar 7, 2018

this should be solved by #733

@andrewrk andrewrk modified the milestones: 0.2.0, 0.3.0 Mar 7, 2018
@andrewrk
Copy link
Member Author

andrewrk commented Sep 3, 2018

This was fixed in 472b7ef because of implementing #733

@andrewrk andrewrk closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals. os-windows upstream An issue with a third party project that Zig uses.
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@andrewrk