stage2: resolve panic on array-like tuple initialization #11185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
commented
Mar 15, 2022
| @@ -3218,6 +3213,12 @@ fn zirValidateArrayInit( | |||
| break :inst block.instructions.items[block_index + 1]; | |||
| }; | |||
|
|
|||
| // Array has one possible value, so value is always comptime-known | |||
There was a problem hiding this comment.
This usage of OPV seems like it might be incorrect for tuples, since they can have OPV without that being shared by all their elements.
I kept it all the same for now, since this change is just to make sure that the calculation of first_block_index is not skipped.
I think we can tackle the array/tuple init differences in another PR, along with #11182
topolarity
force-pushed
the
bugfix-11159
branch
from
c50d36f to
128194e
Compare
This resolves ziglang#11159 The problem was that: 1. We were not correctly deleting the field stores after recognizing that an array initializer was a comptime-known value. 2. LLVM was not checking that the final type had no runtime bits, and so would generate an invalid store. This also adds several test cases for related bugs, just to check these in for later work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #11159
Assorted fixes here:
This also adds several test cases for related bugs, just to check these in for later work. Initializing tuples with mixed comptime/runtime fields is unfortunately still broken (on both stage1 and stage2) - that will have to be tackled later, probably with #11162