Add file support for incremental compile error tests #11417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile error test cases can now be given as a sequence of files: - "foo.1.zig" - "foo.2.zig" - "foo.3.zig" - etc. This sequence of files is tested as incremental compilation updates to a single "foo.zig" source file. To help avoid mistakes, we enforce strict ordering for these files. "foo.zig" cannot co-exist with "foo.X.zig", the sequence must include "foo.1.zig", and no numbers may be skipped.
topolarity
force-pushed
the
incremental-tests
branch
from
76a9f47 to
879b562
Compare
|
Looks great! I would like to take you on your offer to make them zero-indexed. Mind if I hit merge and then that can be a follow-up PR along with (I'm guessing) migration of existing incremental compilation test cases to this new system? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile error test cases can now be given as a sequence of files:
foo.1.zig, foo.2.zig, foo.3.zig, etc...As recommended in #11288, "foo.zig" may not co-exist with "foo.X.zig", and no numbers may be skipped in the test sequence. This implementation also has a couple of slight differences:
1-indexing was chosen so that it will match update progress number "[x/N]" reported in the log. I've also updated a few other places where we report the update number, to make sure it is consistently 1-indexed.
If you'd prefer to make this 0-indexed or to use the original
_suffix, let me know and I'm happy to update the changes 👍