parser: add error for ambiguous operator precedence #18341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nektro
force-pushed
the
patch-6
branch
2 times, most recently
from
0c51479 to
cfe9dad
Compare
Vexu
reviewed
Dec 22, 2023
nektro
force-pushed
the
patch-6
branch
2 times, most recently
from
6f78207 to
00e1c4b
Compare
Vexu
approved these changes
Jan 4, 2024
Comment on lines
+1702
to
+1703
| if (prev_op == .plus and tok_tag == .minus) break :blk; | ||
| if (prev_op == .minus and tok_tag == .plus) break :blk; | ||
| if (prev_op == .plus_percent and tok_tag == .minus_percent) break :blk; | ||
| if (prev_op == .minus_percent and tok_tag == .plus_percent) break :blk; | ||
| if (prev_op == .plus_pipe and tok_tag == .minus_pipe) break :blk; | ||
| if (prev_op == .minus_pipe and tok_tag == .plus_pipe) break :blk; | ||
|
|
||
| if (prev_op == .asterisk and tok_tag == .slash) break :blk; | ||
| if (prev_op == .slash and tok_tag == .asterisk) break :blk; |
There was a problem hiding this comment.
IMO it'd be better to allow mixing all operators with the same precedence (except maybe || and ** which could also have their precedences raised) but I'm fine with this too.
nektro
force-pushed
the
patch-6
branch
2 times, most recently
from
653f53d to
70247a5
Compare
|
pinging since its been a month |
|
This bitrotted before I had a chance to look at it again. I'm sorry for that. Please open a fresh one if you want to roll the dice again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
special-cased groupings of
+-(plus the wrapping and saturating variants) and*/to absolve the most common and obvious occurrence.all other non-parenthesized groupings of same-precedence operators will trip this.
Fixes #1902
Fixes #114