std.fmt: support vector formatting #3904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavika13
reviewed
Dec 14, 2019
daurnimator
added
the
standard library
10 tasks
hatahet
reviewed
Jan 4, 2020
fengb
reviewed
Jan 7, 2020
andrewrk
requested changes
Jan 7, 2020
lib/std/fmt.zig
Outdated
| } | ||
|
|
||
| if (builtin.arch == .mipsel) { | ||
| return error.SkipZigTest; |
There was a problem hiding this comment.
Can you link to the relevant issue here?
There was a problem hiding this comment.
Sadly not.
I noticed that the tests for mipsel did not pass in CI after initial commit of this PR.
There was a problem hiding this comment.
Let's see the CI results now :)
|
I'm wondered why Windows tests failed. |
|
These are good contributions I think, why did you close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.